fixes #586 FormData.FormValue cannot be handled by Jackson JSON parser #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefperito
reviewed
Jul 23, 2019
jefperito
reviewed
Jul 23, 2019
jefperito
reviewed
Jul 23, 2019
|
In most of the cases, we don't need the comment like this; however, this bug was escaped from our code review before due to the special data structure and interaction with the Jackson. I think the comment will help us to pay more attention to the detail in other cases. Also, it lets other developers know why we have made the change. |
jiachen1120
approved these changes
Jul 23, 2019
BalloonWen
approved these changes
Jul 23, 2019
stevehu
added a commit
that referenced
this pull request
Jul 23, 2019
younggwon1
pushed a commit
to younggwon1/light-4j
that referenced
this pull request
Feb 10, 2024
…SON parser (networknt#587) * fixes networknt#586 FormData.FormValue cannot be handled by Jackson JSON parser * fixes networknt#586 update the format based on the code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.