-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/#239 when generate test cases for handler, now will use example of request body to test. #240
Conversation
@BalloonWen could you resolve the conflicts? |
@NicholasAzar @stevehu @BalloonWen Hey! I have further improved this feature and resolved conflict. Look forward to your review! |
@jiachen1120 Have you encountered any issue with the rocker 1.2.1? The new rocker version handles the whitespaces much better. I have reviewed the changelog and couldn't find any compatibility issue. I am wondering if we should give it a try since the generated code formatted much better than before. |
@stevehu I am not sure whether it's newer version of rocker. I had to spend
some time to achieve the formatting you observed in my PR.
…On Wed, Mar 13, 2019, 6:04 PM Steve Hu ***@***.***> wrote:
@jiachen1120 <https://github.com/jiachen1120> Have you encountered any
issue with the rocker 1.2.1? The new rocker version handles the whitespaces
much better. I have reviewed the changelog and couldn't find any
compatibility issue. I am wondering if we should give it a try since the
generated code formatted much better than before.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#240 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACk9w-y5tkXeS09Rl04yyfzXwGoGDwZ2ks5vWaAngaJpZM4bZMMb>
.
|
@243826 Thanks for the confirmation. I didn't realize that the format is purely done manually. Nice job!!! I am still thinking that we should try out the latest version until we encounter some issues. Then we can rollback to 1.0.0 instead of 0.22 as it is not supposed for production usage in common practice. |
@stevehu Good morning! Yesterday I used the new version and found that I couldn't compile, the problem I thought was about rocker, and then I just found out that it was actually a problem with my IDE. Has been resolved and updated the rocker version to 1.2.1 |
related issue: #239
when generate test cases for handler, now will use example of request body to test.