Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#239 when generate test cases for handler, now will use example of request body to test. #240

Merged
merged 10 commits into from
Mar 21, 2019

Conversation

BalloonWen
Copy link
Contributor

related issue: #239
when generate test cases for handler, now will use example of request body to test.

@whoamnick
Copy link
Member

@BalloonWen could you resolve the conflicts?

@jiachen1120
Copy link
Contributor

jiachen1120 commented Mar 13, 2019

@NicholasAzar @stevehu @BalloonWen Hey! I have further improved this feature and resolved conflict.
In addition, the new version of rocker may not backward compatible, so I revert it to use version 0.22.0 which we used before.

Look forward to your review!

@stevehu
Copy link
Contributor

stevehu commented Mar 14, 2019

@jiachen1120 Have you encountered any issue with the rocker 1.2.1? The new rocker version handles the whitespaces much better. I have reviewed the changelog and couldn't find any compatibility issue. I am wondering if we should give it a try since the generated code formatted much better than before.

@243826
Copy link
Contributor

243826 commented Mar 14, 2019 via email

@stevehu
Copy link
Contributor

stevehu commented Mar 14, 2019

@243826 Thanks for the confirmation. I didn't realize that the format is purely done manually. Nice job!!! I am still thinking that we should try out the latest version until we encounter some issues. Then we can rollback to 1.0.0 instead of 0.22 as it is not supposed for production usage in common practice.

@jiachen1120
Copy link
Contributor

@stevehu Good morning! Yesterday I used the new version and found that I couldn't compile, the problem I thought was about rocker, and then I just found out that it was actually a problem with my IDE. Has been resolved and updated the rocker version to 1.2.1

@stevehu stevehu merged commit 83227e5 into develop Mar 21, 2019
@stevehu stevehu deleted the feat/#239 branch March 21, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants