Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging Status with JSON format #156

Closed
BalloonWen opened this issue Dec 16, 2020 · 3 comments · Fixed by #157
Closed

logging Status with JSON format #156

BalloonWen opened this issue Dec 16, 2020 · 3 comments · Fixed by #157
Assignees

Comments

@BalloonWen
Copy link
Contributor

BalloonWen commented Dec 16, 2020

logging status info with JSON format instead of Stringified JSON
eg. logger.error("ValidationError:" + status.toString());
status.toString() is pure JSON, but with prefix ValidationError, it cannot be recognized by logging framework.

@BalloonWen BalloonWen self-assigned this Dec 16, 2020
BalloonWen added a commit that referenced this issue Dec 17, 2020
logging status separately
@BalloonWen BalloonWen linked a pull request Dec 17, 2020 that will close this issue
stevehu pushed a commit that referenced this issue Dec 17, 2020
logging status separately
@stevehu
Copy link
Contributor

stevehu commented Dec 17, 2020

@stevehu
Copy link
Contributor

stevehu commented Dec 17, 2020

For some users, they are using the JSON appenders so that the logs can be injected into Splunk. Mixing string and JSON in the same logging statement will cause issues for those appenders.

@stevehu
Copy link
Contributor

stevehu commented Dec 17, 2020

@BalloonWen Thanks a lot for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants