Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handler.basePath not being used when no base path specified in provided openapi spec #278

Closed
KalevGonvick opened this issue Jan 25, 2023 · 0 comments · Fixed by #279
Closed

handler.basePath not being used when no base path specified in provided openapi spec #278

KalevGonvick opened this issue Jan 25, 2023 · 0 comments · Fixed by #279
Assignees
@KalevGonvick

Comments

@KalevGonvick
Copy link
Member

  • instead of using handler.basePath from configs when base path is not set in the design spec, the base path is set to an empty string instead
@KalevGonvick KalevGonvick self-assigned this Jan 25, 2023
@KalevGonvick KalevGonvick linked a pull request Jan 25, 2023 that will close this issue
basePath property fix #279
Merged
@stevehu stevehu changed the title 'handler.basePath' not being used when no base path specified in provided openapi spec handler.basePath not being used when no base path specified in provided openapi spec Jan 26, 2023
stevehu added a commit that referenced this issue Jan 26, 2023
@stevehu
fixes #278 overwrite the basePath from handler.yml if it is not null
a27fde9
stevehu added a commit that referenced this issue Jan 26, 2023
@stevehu
fixes #278 overwrite the basePath from handler.yml if it is not null (#…
695186f 
…280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KalevGonvick KalevGonvick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

basePath property fix networknt/light-rest-4j
1 participant
@KalevGonvick