Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basePath property fix #279

Merged
merged 1 commit into from Jan 25, 2023
Merged

basePath property fix #279

merged 1 commit into from Jan 25, 2023

Conversation

KalevGonvick
Copy link
Member

  • Condensed some code for reuse
  • Changed null check to empty string check for setting base path on construction of handler.

@KalevGonvick KalevGonvick linked an issue Jan 25, 2023 that may be closed by this pull request
handler.basePath not being used when no base path specified in provided openapi spec #278
Closed
@stevehu stevehu merged commit d90d58e into master Jan 25, 2023
@stevehu stevehu deleted the 278-handlerbasepath-not-being-used-when-no-base-path-specified-in-provided-openapi-spec branch January 25, 2023 21:20
@stevehu
Copy link
Contributor

stevehu commented Jan 25, 2023

@KalevGonvick Thanks a lot for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehu stevehu stevehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

handler.basePath not being used when no base path specified in provided openapi spec
2 participants
@KalevGonvick @stevehu