Added retry 'registry' chain element

[sol-0]

Signed-off-by: Oleg Solodkov oleg.solodkov@xored.com

Issue link

Fixes #1201

How Has This Been Tested?

• Added unit testing to cover
• Tested manually
• Tested by integration testing
• Have not tested

Types of changes

• Bug fix
• New functionallity
• Documentation
• Refactoring
• CI

[denis-tingaikin]

Suggested change

	apply(configurable)
	apply(*options)

[sol-0]

Done

[denis-tingaikin]

Suggested change

	type configurable interface {
	setInterval(time.Duration)
	setTryTimeout(time.Duration)
	}
	type options interface {
	internal time.Duration
	timeout time.Duration
	}

[sol-0]

Done

[denis-tingaikin]

Suggested change

	type applier func(configurable)
	func (f applier) apply(c configurable) {
	f(c)
	}

[sol-0]

Done

[denis-tingaikin]

These fields are not used. Please don't add dead code.

Suggested change

	registers, unregisters, finds map[string]int32
	mu sync.Mutex

[sol-0]

Done

[denis-tingaikin]

Suggested change

	type NSEClient struct {
	type countNSEClient struct {

[denis-tingaikin]

This can be private.

[sol-0]

Done

[denis-tingaikin]

Suggested change

	totalRegisterCalls, totalUnregisterCalls, totalFindCalls int32
	totalRegisterCalls, totalUnregisterCalls, totalFindCalls *int32

[sol-0]

Done

[denis-tingaikin]

Suggested change

	// Registers returns Register call count
	func (c *NSEClient) Registers() int {
	return int(atomic.LoadInt32(&c.totalRegisterCalls))
	}
	// Unregisters returns Unregister count
	func (c *NSEClient) Unregisters() int {
	return int(atomic.LoadInt32(&c.totalUnregisterCalls))
	}
	// Finds returns Find count
	func (c *NSEClient) Finds() int {
	return int(atomic.LoadInt32(&c.totalFindCalls))
	}

[sol-0]

How do we assert Register/Unregister/Find call count in tests?

[denis-tingaikin]

@sol-0 Does #1202 (comment) resolve your question?

[sol-0]

@denis-tingaikin yes, thanks! Done

[denis-tingaikin]

Suggested change

	func NewNetworkServiceEndpointClinet(opts...options) registry.NetworkServiceEndpointClient {
	var result = &countNSEClient{
	totalRegisterCalls: new(int32)
	//TODO totalUnregisterCalls, totalFindCalls
	}
	for _, opt := range options {
	opt(result)
	}
	return result
	}

where options

WithRegisters(r *int32) func(*options)
....

[sol-0]

Done

[denis-tingaikin]

@sol-0 Please ping me when you've resolved all comments.

[sol-0]

@denis-tingaikin, comments have been addressed - please, take a look.

[denis-tingaikin]

Suggested change

	type options struct {
	totalRegisterCalls, totalUnregisterCalls, totalFindCalls *int32
	}
	// Option is an option pattern for NewNetworkServiceRegistryClient, NewNetworkServiceEndpointRegistryClient
	type Option func(*options)
	// WithTotalRegisterCalls sets pointer to number of Register calls
	func WithTotalRegisterCalls(registerCount *int32) func(*options) {
	return func(o *options) {
	o.totalRegisterCalls = registerCount
	}
	}
	// WithTotalUnregisterCalls sets pointer to number of Unregister calls
	func WithTotalUnregisterCalls(unregisterCount *int32) func(*options) {
	return func(o *options) {
	o.totalUnregisterCalls = unregisterCount
	}
	}
	// WithTotalFindCalls sets pointer to number of Find calls
	func WithTotalFindCalls(findCalls *int32) func(*options) {
	return func(o *options) {
	o.totalFindCalls = findCalls
	}
	}
	type Counter struct {
	totalRegisterCalls int32
	totalUnregisterCalls int32
	totalFindCalls int32
	}
	// Registers returns Register call count
	func (c *Counter) Registers() int {
	return int(atomic.LoadInt32(&c.totalRegisterCalls))
	}
	// Unregisters returns Unregister count
	func (c *Counter) Unregisters() int {
	return int(atomic.LoadInt32(&c.totalUnregisterCalls))
	}
	// Finds returns Find count
	func (c *Counter) Finds() int {
	return int(atomic.LoadInt32(&c.totalFindCalls))
	}
	// TODO: add this to the constructor of count servers

[sol-0]

Done