Add cleanup chain element #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
| type Option func(*options) | ||
|
|
||
| // WithCCClose - closes clientconn to prevent calling requests/closes on other datapath objects | ||
| func WithCCClose() Option { |
There was a problem hiding this comment.
Can we rename this to something readable?
Suggested change
| func WithCCClose() Option { | |
| func WithLocalClose() Option { |
Chunosov
approved these changes
Mar 16, 2022
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
denis-tingaikin
approved these changes
Mar 16, 2022
NikitaSkrynnik
approved these changes
Mar 16, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Mar 16, 2022
…k@main PR link: networkservicemesh/sdk#1246 Commit: b88289b Author: Artem Glazychev Date: 2022-03-16 17:50:41 +0700 Message: - Add cleanup chain element (#1246) * Add cleanup chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Rename option Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Mar 16, 2022
…k@main PR link: networkservicemesh/sdk#1246 Commit: b88289b Author: Artem Glazychev Date: 2022-03-16 17:50:41 +0700 Message: - Add cleanup chain element (#1246) * Add cleanup chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Rename option Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Mar 16, 2022
…k@main PR link: networkservicemesh/sdk#1246 Commit: b88289b Author: Artem Glazychev Date: 2022-03-16 17:50:41 +0700 Message: - Add cleanup chain element (#1246) * Add cleanup chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Rename option Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Mar 16, 2022
…k@main PR link: networkservicemesh/sdk#1246 Commit: b88289b Author: Artem Glazychev Date: 2022-03-16 17:50:41 +0700 Message: - Add cleanup chain element (#1246) * Add cleanup chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Rename option Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Mar 16, 2022
…k@main PR link: networkservicemesh/sdk#1246 Commit: b88289b Author: Artem Glazychev Date: 2022-03-16 17:50:41 +0700 Message: - Add cleanup chain element (#1246) * Add cleanup chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Rename option Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Mar 16, 2022
…k@main PR link: networkservicemesh/sdk#1246 Commit: b88289b Author: Artem Glazychev Date: 2022-03-16 17:50:41 +0700 Message: - Add cleanup chain element (#1246) * Add cleanup chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Rename option Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Mar 16, 2022
…k@main PR link: networkservicemesh/sdk#1246 Commit: b88289b Author: Artem Glazychev Date: 2022-03-16 17:50:41 +0700 Message: - Add cleanup chain element (#1246) * Add cleanup chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Rename option Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Mar 16, 2022
…k@main PR link: networkservicemesh/sdk#1246 Commit: b88289b Author: Artem Glazychev Date: 2022-03-16 17:50:41 +0700 Message: - Add cleanup chain element (#1246) * Add cleanup chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Rename option Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Mar 16, 2022
…k@main PR link: networkservicemesh/sdk#1246 Commit: b88289b Author: Artem Glazychev Date: 2022-03-16 17:50:41 +0700 Message: - Add cleanup chain element (#1246) * Add cleanup chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Rename option Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Mar 16, 2022
…k@main PR link: networkservicemesh/sdk#1246 Commit: b88289b Author: Artem Glazychev Date: 2022-03-16 17:50:41 +0700 Message: - Add cleanup chain element (#1246) * Add cleanup chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Rename option Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Glazychev artem.glazychev@xored.com
Description
This PR adds new chain element that cleans up resources on
chainCtx.Done()Issue link
Issue: networkservicemesh/sdk-vpp#516
How Has This Been Tested?
Types of changes