Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OPA version with other dependecies #1335

Merged
merged 5 commits into from
Aug 22, 2022
Merged

Update OPA version with other dependecies #1335

merged 5 commits into from
Aug 22, 2022

Conversation

anastasia-malysheva
Copy link
Contributor

Description

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@anastasia-malysheva
update dependencies
bd28798 
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
@anastasia-malysheva
Merge branch 'main' of github.com:anastasia-malysheva/sdk into update…
6b81c24 
…-opa-version
@anastasia-malysheva
remove redundant go.gen changes and remove redundant usage of grpcfd
7919eb6 
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
@denis-tingaikin
Copy link
Member

@fkautz

Here I see two options on how to merge this:

  1. Split this PR to small PR and update each required dependency for OPA separately.
  2. Just merge this PR
  3. Your option.

Thoughts?

@denis-tingaikin
Copy link
Member

@anastasia-malysheva Have you updated all deps or only that related to opa?

@anastasia-malysheva
Copy link
Contributor Author

@anastasia-malysheva Have you updated all deps or only that related to opa?

I've updated all deps.

@anastasia-malysheva
remove changes for non-related to OPA dependencies
30c5371 
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
@anastasia-malysheva
Copy link
Contributor Author

@denis-tingaikin I've removed updates for dependencies which are not related to OPA.

NikitaSkrynnik
NikitaSkrynnik reviewed Aug 16, 2022
View reviewed changes
pkg/networkservice/chains/endpoint/combine_test.go Outdated
@@ -1,4 +1,4 @@
// Copyright (c) 2021 Doc.ai and/or its affiliates.
// Copyright (c) 2022 Doc.ai and/or its affiliates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright (c) 2022 Doc.ai and/or its affiliates.
// Copyright (c) 2021-2022 Doc.ai and/or its affiliates.

NikitaSkrynnik
NikitaSkrynnik reviewed Aug 16, 2022
View reviewed changes
pkg/networkservice/common/monitor/passthrough_test.go Outdated
@@ -1,4 +1,4 @@
// Copyright (c) 2021 Cisco and/or its affiliates.
// Copyright (c) 2022 Cisco and/or its affiliates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright (c) 2022 Cisco and/or its affiliates.
// Copyright (c) 2021-2022 Cisco and/or its affiliates.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NikitaSkrynnik fixed

denis-tingaikin
denis-tingaikin reviewed Aug 22, 2022
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anastasia-malysheva Please resolve comments and this may be merged

@anastasia-malysheva
fixes after comments
b46c003 
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
denis-tingaikin
denis-tingaikin reviewed Aug 22, 2022
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edwarnicke We're merging this to check NSM on CI with new deps.

We'll revert these changes if we'll get any regressions

@denis-tingaikin denis-tingaikin merged commit a7b84cf into networkservicemesh:main Aug 22, 2022
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Aug 22, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2a56ee0 
…k@main

PR link: networkservicemesh/sdk#1335

Commit: a7b84cf
Author: anastasia-malysheva
Date: 2022-08-23 02:08:26 +0700
Message:
  - Update OPA version with other dependecies  (#1335)
* update dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove redundant go.gen changes and remove redundant usage of grpcfd

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove changes for non-related to OPA dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* fixes after comments

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Aug 22, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
47e1904 
…k@main

PR link: networkservicemesh/sdk#1335

Commit: a7b84cf
Author: anastasia-malysheva
Date: 2022-08-23 02:08:26 +0700
Message:
  - Update OPA version with other dependecies  (#1335)
* update dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove redundant go.gen changes and remove redundant usage of grpcfd

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove changes for non-related to OPA dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* fixes after comments

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Aug 22, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
dfd6471 
…k@main

PR link: networkservicemesh/sdk#1335

Commit: a7b84cf
Author: anastasia-malysheva
Date: 2022-08-23 02:08:26 +0700
Message:
  - Update OPA version with other dependecies  (#1335)
* update dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove redundant go.gen changes and remove redundant usage of grpcfd

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove changes for non-related to OPA dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* fixes after comments

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Aug 22, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
93927c0 
…k@main

PR link: networkservicemesh/sdk#1335

Commit: a7b84cf
Author: anastasia-malysheva
Date: 2022-08-23 02:08:26 +0700
Message:
  - Update OPA version with other dependecies  (#1335)
* update dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove redundant go.gen changes and remove redundant usage of grpcfd

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove changes for non-related to OPA dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* fixes after comments

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Aug 22, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6c7c57c 
…k@main

PR link: networkservicemesh/sdk#1335

Commit: a7b84cf
Author: anastasia-malysheva
Date: 2022-08-23 02:08:26 +0700
Message:
  - Update OPA version with other dependecies  (#1335)
* update dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove redundant go.gen changes and remove redundant usage of grpcfd

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove changes for non-related to OPA dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* fixes after comments

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Aug 22, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
17e02eb 
…k@main

PR link: networkservicemesh/sdk#1335

Commit: a7b84cf
Author: anastasia-malysheva
Date: 2022-08-23 02:08:26 +0700
Message:
  - Update OPA version with other dependecies  (#1335)
* update dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove redundant go.gen changes and remove redundant usage of grpcfd

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove changes for non-related to OPA dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* fixes after comments

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Aug 22, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5348a0a 
…k@main

PR link: networkservicemesh/sdk#1335

Commit: a7b84cf
Author: anastasia-malysheva
Date: 2022-08-23 02:08:26 +0700
Message:
  - Update OPA version with other dependecies  (#1335)
* update dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove redundant go.gen changes and remove redundant usage of grpcfd

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove changes for non-related to OPA dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* fixes after comments

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Aug 22, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9009f59 
…k@main

PR link: networkservicemesh/sdk#1335

Commit: a7b84cf
Author: anastasia-malysheva
Date: 2022-08-23 02:08:26 +0700
Message:
  - Update OPA version with other dependecies  (#1335)
* update dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove redundant go.gen changes and remove redundant usage of grpcfd

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove changes for non-related to OPA dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* fixes after comments

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Aug 22, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d880e81 
…k@main

PR link: networkservicemesh/sdk#1335

Commit: a7b84cf
Author: anastasia-malysheva
Date: 2022-08-23 02:08:26 +0700
Message:
  - Update OPA version with other dependecies  (#1335)
* update dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove redundant go.gen changes and remove redundant usage of grpcfd

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove changes for non-related to OPA dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* fixes after comments

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Aug 22, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8d2d445 
…k@main

PR link: networkservicemesh/sdk#1335

Commit: a7b84cf
Author: anastasia-malysheva
Date: 2022-08-23 02:08:26 +0700
Message:
  - Update OPA version with other dependecies  (#1335)
* update dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove redundant go.gen changes and remove redundant usage of grpcfd

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove changes for non-related to OPA dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* fixes after comments

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Aug 22, 2022
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Aug 22, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
dea392f 
…k@main

PR link: networkservicemesh/sdk#1335

Commit: a7b84cf
Author: anastasia-malysheva
Date: 2022-08-23 02:08:26 +0700
Message:
  - Update OPA version with other dependecies  (#1335)
* update dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove redundant go.gen changes and remove redundant usage of grpcfd

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove changes for non-related to OPA dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* fixes after comments

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Aug 22, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f173f21 
…k@main

PR link: networkservicemesh/sdk#1335

Commit: a7b84cf
Author: anastasia-malysheva
Date: 2022-08-23 02:08:26 +0700
Message:
  - Update OPA version with other dependecies  (#1335)
* update dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove redundant go.gen changes and remove redundant usage of grpcfd

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove changes for non-related to OPA dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* fixes after comments

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Aug 22, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Aug 22, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
75dce9e 
…k@main

PR link: networkservicemesh/sdk#1335

Commit: a7b84cf
Author: anastasia-malysheva
Date: 2022-08-23 02:08:26 +0700
Message:
  - Update OPA version with other dependecies  (#1335)
* update dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove redundant go.gen changes and remove redundant usage of grpcfd

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* remove changes for non-related to OPA dependencies

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>

* fixes after comments

Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Aug 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikitaSkrynnik NikitaSkrynnik NikitaSkrynnik left review comments

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@glazychev-art glazychev-art Awaiting requested review from glazychev-art

@fkautz fkautz Awaiting requested review from fkautz

@edwarnicke edwarnicke Awaiting requested review from edwarnicke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anastasia-malysheva @denis-tingaikin @NikitaSkrynnik