Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

begin: update context after a successful request #1370

Merged
merged 1 commit into from
Oct 13, 2022
Merged

begin: update context after a successful request #1370

merged 1 commit into from
Oct 13, 2022

Conversation

glazychev-art
Copy link
Contributor

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

We should update the eventFactory context only after successful refresh.

The reason: we update eventFactory request only if we don't have an error - https://github.com/networkservicemesh/sdk/blob/main/pkg/networkservice/common/begin/server.go#L75-L77

Thus, if we update the context before the request and it fails, we will have the wrong state (new context but previous request)

Issue link

#1357

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@glazychev-art
begin: update context after a successful request
db42a65 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@denis-tingaikin denis-tingaikin merged commit 9ae27f8 into networkservicemesh:main Oct 13, 2022
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Oct 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1e25fc9 
…k@main

PR link: networkservicemesh/sdk#1370

Commit: 9ae27f8
Author: Artem Glazychev
Date: 2022-10-13 15:25:56 +0700
Message:
  - begin: update context after a successful request (#1370)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Oct 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
65fffa5 
…k@main

PR link: networkservicemesh/sdk#1370

Commit: 9ae27f8
Author: Artem Glazychev
Date: 2022-10-13 15:25:56 +0700
Message:
  - begin: update context after a successful request (#1370)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Oct 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f78e22a 
…k@main

PR link: networkservicemesh/sdk#1370

Commit: 9ae27f8
Author: Artem Glazychev
Date: 2022-10-13 15:25:56 +0700
Message:
  - begin: update context after a successful request (#1370)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Oct 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2c56224 
…k@main

PR link: networkservicemesh/sdk#1370

Commit: 9ae27f8
Author: Artem Glazychev
Date: 2022-10-13 15:25:56 +0700
Message:
  - begin: update context after a successful request (#1370)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Oct 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
230a9f6 
…k@main

PR link: networkservicemesh/sdk#1370

Commit: 9ae27f8
Author: Artem Glazychev
Date: 2022-10-13 15:25:56 +0700
Message:
  - begin: update context after a successful request (#1370)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Oct 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e206fff 
…k@main

PR link: networkservicemesh/sdk#1370

Commit: 9ae27f8
Author: Artem Glazychev
Date: 2022-10-13 15:25:56 +0700
Message:
  - begin: update context after a successful request (#1370)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Oct 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
70f03a0 
…k@main

PR link: networkservicemesh/sdk#1370

Commit: 9ae27f8
Author: Artem Glazychev
Date: 2022-10-13 15:25:56 +0700
Message:
  - begin: update context after a successful request (#1370)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Oct 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6884af4 
…k@main

PR link: networkservicemesh/sdk#1370

Commit: 9ae27f8
Author: Artem Glazychev
Date: 2022-10-13 15:25:56 +0700
Message:
  - begin: update context after a successful request (#1370)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Oct 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
cee6802 
…k@main

PR link: networkservicemesh/sdk#1370

Commit: 9ae27f8
Author: Artem Glazychev
Date: 2022-10-13 15:25:56 +0700
Message:
  - begin: update context after a successful request (#1370)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Oct 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d32ea59 
…k@main

PR link: networkservicemesh/sdk#1370

Commit: 9ae27f8
Author: Artem Glazychev
Date: 2022-10-13 15:25:56 +0700
Message:
  - begin: update context after a successful request (#1370)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Oct 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
62f6d30 
…k@main

PR link: networkservicemesh/sdk#1370

Commit: 9ae27f8
Author: Artem Glazychev
Date: 2022-10-13 15:25:56 +0700
Message:
  - begin: update context after a successful request (#1370)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Oct 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
90642e9 
…k@main

PR link: networkservicemesh/sdk#1370

Commit: 9ae27f8
Author: Artem Glazychev
Date: 2022-10-13 15:25:56 +0700
Message:
  - begin: update context after a successful request (#1370)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Oct 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f04bb7f 
…k@main

PR link: networkservicemesh/sdk#1370

Commit: 9ae27f8
Author: Artem Glazychev
Date: 2022-10-13 15:25:56 +0700
Message:
  - begin: update context after a successful request (#1370)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 13, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Oct 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a31ee06 
…k@main

PR link: networkservicemesh/sdk#1370

Commit: 9ae27f8
Author: Artem Glazychev
Date: 2022-10-13 15:25:56 +0700
Message:
  - begin: update context after a successful request (#1370)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Oct 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
da7036b 
…k@main

PR link: networkservicemesh/sdk#1370

Commit: 9ae27f8
Author: Artem Glazychev
Date: 2022-10-13 15:25:56 +0700
Message:
  - begin: update context after a successful request (#1370)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Oct 16, 2022
Merged
@nsmbot nsmbot mentioned this pull request Oct 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glazychev-art @denis-tingaikin