Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add groupipam networkservice server chain element #1407

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

denis-tingaikin
Copy link
Member

Signed-off-by: denis-tingaikin denis.tingajkin@xored.com

Description

Reduces code for nses.

For example, these lines could be removed with this patch

  1. https://github.com/networkservicemesh/cmd-nse-icmp-responder/blob/main/main.go#L409-L415
  2. https://github.com/networkservicemesh/cmd-nse-icmp-responder-vpp/blob/main/main.go#L328-L334
  3. https://github.com/networkservicemesh/cmd-nse-remote-vlan/blob/main/main.go#L318-L329

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
Copy link
Member Author

@glazychev-art , @edwarnicke Could you have a look?

@denis-tingaikin denis-tingaikin self-assigned this Jan 9, 2023
@edwarnicke edwarnicke merged commit 61629de into main Jan 9, 2023
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Jan 9, 2023
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jan 9, 2023
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Jan 9, 2023
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jan 9, 2023
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Jan 9, 2023
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Jan 9, 2023
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jan 9, 2023
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Jan 9, 2023
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Jan 9, 2023
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jan 9, 2023
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Jan 9, 2023
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jan 9, 2023
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jan 9, 2023
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants