Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix heal after failed refresh #1563

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Fix heal after failed refresh #1563

merged 2 commits into from
Dec 12, 2023

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Dec 11, 2023 •
edited
Loading

Description

Issue link

networkservicemesh/cmd-forwarder-vpp#664

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@glazychev-art
Fix heal after failed refresh
feb6c93 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
denis-tingaikin
denis-tingaikin approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glazychev-art
Fix monitor server
0c28650 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@821b4bc). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1563   +/-   ##
=======================================
  Coverage        ?   67.17%           
=======================================
  Files           ?      260           
  Lines           ?    12340           
  Branches        ?        0           
=======================================
  Hits            ?     8290           
  Misses          ?     3529           
  Partials        ?      521

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glazychev-art glazychev-art marked this pull request as ready for review December 12, 2023 10:31
@denis-tingaikin denis-tingaikin merged commit 1979cc1 into networkservicemesh:main Dec 12, 2023
17 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Dec 12, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ddeef0a 
…k@main

PR link: networkservicemesh/sdk#1563

Commit: 1979cc1
Author: Artem Glazychev
Date: 2023-12-12 17:32:12 +0700
Message:
  - Fix heal after failed refresh (#1563)
* Fix heal after failed refresh

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Fix monitor server

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Dec 12, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e9427f2 
…k@main

PR link: networkservicemesh/sdk#1563

Commit: 1979cc1
Author: Artem Glazychev
Date: 2023-12-12 17:32:12 +0700
Message:
  - Fix heal after failed refresh (#1563)
* Fix heal after failed refresh

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Fix monitor server

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Dec 12, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5215649 
…k@main

PR link: networkservicemesh/sdk#1563

Commit: 1979cc1
Author: Artem Glazychev
Date: 2023-12-12 17:32:12 +0700
Message:
  - Fix heal after failed refresh (#1563)
* Fix heal after failed refresh

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Fix monitor server

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Dec 12, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
991e7e3 
…k@main

PR link: networkservicemesh/sdk#1563

Commit: 1979cc1
Author: Artem Glazychev
Date: 2023-12-12 17:32:12 +0700
Message:
  - Fix heal after failed refresh (#1563)
* Fix heal after failed refresh

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Fix monitor server

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Dec 12, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c92d6c2 
…k@main

PR link: networkservicemesh/sdk#1563

Commit: 1979cc1
Author: Artem Glazychev
Date: 2023-12-12 17:32:12 +0700
Message:
  - Fix heal after failed refresh (#1563)
* Fix heal after failed refresh

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Fix monitor server

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Dec 12, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d87c134 
…k@main

PR link: networkservicemesh/sdk#1563

Commit: 1979cc1
Author: Artem Glazychev
Date: 2023-12-12 17:32:12 +0700
Message:
  - Fix heal after failed refresh (#1563)
* Fix heal after failed refresh

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Fix monitor server

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Dec 12, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b8e6776 
…k@main

PR link: networkservicemesh/sdk#1563

Commit: 1979cc1
Author: Artem Glazychev
Date: 2023-12-12 17:32:12 +0700
Message:
  - Fix heal after failed refresh (#1563)
* Fix heal after failed refresh

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Fix monitor server

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Dec 12, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1f977dc 
…k@main

PR link: networkservicemesh/sdk#1563

Commit: 1979cc1
Author: Artem Glazychev
Date: 2023-12-12 17:32:12 +0700
Message:
  - Fix heal after failed refresh (#1563)
* Fix heal after failed refresh

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Fix monitor server

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Dec 12, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
18609f1 
…k@main

PR link: networkservicemesh/sdk#1563

Commit: 1979cc1
Author: Artem Glazychev
Date: 2023-12-12 17:32:12 +0700
Message:
  - Fix heal after failed refresh (#1563)
* Fix heal after failed refresh

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Fix monitor server

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Dec 12, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fd77090 
…k@main

PR link: networkservicemesh/sdk#1563

Commit: 1979cc1
Author: Artem Glazychev
Date: 2023-12-12 17:32:12 +0700
Message:
  - Fix heal after failed refresh (#1563)
* Fix heal after failed refresh

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Fix monitor server

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Dec 12, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6421b93 
…k@main

PR link: networkservicemesh/sdk#1563

Commit: 1979cc1
Author: Artem Glazychev
Date: 2023-12-12 17:32:12 +0700
Message:
  - Fix heal after failed refresh (#1563)
* Fix heal after failed refresh

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Fix monitor server

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Dec 12, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c12964f 
…k@main

PR link: networkservicemesh/sdk#1563

Commit: 1979cc1
Author: Artem Glazychev
Date: 2023-12-12 17:32:12 +0700
Message:
  - Fix heal after failed refresh (#1563)
* Fix heal after failed refresh

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Fix monitor server

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Dec 12, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
be75058 
…k@main

PR link: networkservicemesh/sdk#1563

Commit: 1979cc1
Author: Artem Glazychev
Date: 2023-12-12 17:32:12 +0700
Message:
  - Fix heal after failed refresh (#1563)
* Fix heal after failed refresh

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Fix monitor server

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Dec 12, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8f54d44 
…k@main

PR link: networkservicemesh/sdk#1563

Commit: 1979cc1
Author: Artem Glazychev
Date: 2023-12-12 17:32:12 +0700
Message:
  - Fix heal after failed refresh (#1563)
* Fix heal after failed refresh

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Fix monitor server

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 12, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Dec 12, 2023
Merged
Merged
Merged
denis-tingaikin pushed a commit that referenced this pull request Dec 12, 2023
@glazychev-art @denis-tingaikin
Fix heal after failed refresh (#1563)
da0970e 
* Fix heal after failed refresh

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Fix monitor server

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Dec 13, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5fadc56 
…k@main

PR link: networkservicemesh/sdk#1563

Commit: 1979cc1
Author: Artem Glazychev
Date: 2023-12-12 17:32:12 +0700
Message:
  - Fix heal after failed refresh (#1563)
* Fix heal after failed refresh

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Fix monitor server

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glazychev-art @denis-tingaikin