Add extra error handling for creating vlans #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt852
requested review from
chadell,
glennmatthews and
jvanderaa
as code owners
|
Closes issue #280 |
chadell
reviewed
Sep 19, 2022
| nb_params["tags"].append(tag_id) | ||
| except pynautobot.core.query.RequestError: | ||
| # If there is an error with tag retrieval, ignore tags | ||
| pass |
There was a problem hiding this comment.
shouldn't we log something? (even for DEBUG)
There was a problem hiding this comment.
@chadell Good call. I added a warning message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cases where there is an Exception thrown when trying to retrieve device tags, I added in exception handling to ignore the tags and continue processing the vlan creation.
This resolved the issue when I tested it locally, however it does not necessarily resolve the root cause of the issue, which I believe stems from the
device.get_device_tag_id()method further upstream.