Fix 1376 juniper junos show interfaces #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 29, 2023 21:12
… sort keys, verify yamldiff
…ll end on error tests/juniper_junos/show_interfaces/juniper_junos_show_interfaces2 add new raw and yml test
diepes
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
jvanderaa
reviewed
Aug 7, 2023
jmcgill298
reviewed
Jul 19, 2024
tests/juniper_junos/show_interfaces/juniper_junos_show_interfaces2.raw
Outdated
Show resolved
Hide resolved
jmcgill298
reviewed
Jul 20, 2024
jmcgill298
reviewed
Jul 20, 2024
jmcgill298
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1376 , Fixs_1376, Fix_1376
tasks.py add alias test to tests
juniper junos_show_interfaces
tests/juniper_junos/show_interfaces/juniper_junos_show_interfaces.yml
Sort current test yaml and verify it did not change.
tests/juniper_junos/show_interfaces/juniper_junos_show_interfaces2.raw
add new test file
ntc_templates/templates/juniper_junos_show_interfaces.textfsm
Update template.
match all values in 2 tests and end on "-> Error"
⁇ It seems a bit brittle as Juniper has so many settings that seem to be uniq to each interface type.
Suggest we comment the last line ? (" ^. -> Error")
Probably need more test examples.
⁇ the records are generated on blank lines, couldn't see a better way ?