Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New source tree layout #2

Closed
aquette opened this issue Feb 12, 2013 · 7 comments
Closed

New source tree layout #2

aquette opened this issue Feb 12, 2013 · 7 comments
Milestone

Comments

@aquette
Copy link
Member

aquette commented Feb 12, 2013

FIXME: Need completion from Arno

aquette added a commit that referenced this issue Feb 23, 2013
Address HP USB/HID devices, that use the Eaton HID definitions. This
includes the latest products range (USB IDs 0x1fe5, 0x1fe6, 0x1fe7 and
0x1fe8), and few more variables and commands

Fossil-ID: SVN r3525
aquette added a commit that referenced this issue Feb 23, 2013
Correct the nomenclature of the SmartUPS cabling part numbers
(patch #2 from Greg A. Woods)

Fossil-ID: SVN r3569
aquette added a commit that referenced this issue Feb 23, 2013
Complete previous commit by also adapting paths for service files


Fossil-ID: SVN r3666
aquette added a commit that referenced this issue Feb 23, 2013
Prepare for supporting API changes in FreeIPMI 1.1.x and 1.2.x. This 2nd
patch, which completes [[SVN:3675]], addresses FRU API changes, and removes
code redundancy. This code has been tested with FreeIPMI 0.8.12 and
the latest [[FreeIPMI SVN]] trunk r9505 (reported as 1.2.0.beta2 by pkgconfig)

[[SVN:3675]] = 2012-07-16T13:18:18Z!arnaud.quette@free.fr

Fossil-ID: SVN r3733
clepple added a commit that referenced this issue Feb 23, 2013
Author: Emilien Kia <kiae.dev@gmail.com>

Pull Request #2: "High level C and C++ libnutclient" from
https://github.com/clepple/nut/pull/2 .
Hand-merged into SVN trunk from commit: 701cc571f4f8578e9c82b13c1e9eab509a41cd7f

Fossil-ID: SVN r3776
@clepple
Copy link
Member

clepple commented Feb 25, 2013

^ Unfortunately, none of the preceding commits refer to this particular issue.

If we are thinking about reorganizing, can we do something about the absurdly long Java path names?

The file "jNut/src/main/java/org/networkupstools/jnut/NutException.java" breaks the build if we use a name much longer than "nut-2.x.x" for the tar file in "make distcheck". I realize part of the name is dictated by the reverse-DNS convention, but we could cut out a few of the extra directory levels.

@EmilienKia
Copy link
Contributor

In fact, this is the conjunction of:

  • a typical maven-based project hierarchy (src/main/java - sources/ )
  • a typical java based source hierarchy (org/networkupstools/jnut)
    We can not really truncate that without loose benefit of maven-based projects.
    I agree that is completely silly for beginners to see so many directory levels for few files but it follow a really structured group of rules specified by maven. Maven suggest a structured approach which can be considered as too strict but at usage is really well thunk and clean.

Do we really need a hierarchy simplification for this part ? or is it just a cosmetic problem ?

@clepple
Copy link
Member

clepple commented Feb 25, 2013

On Feb 25, 2013, at 4:22 AM, Emilien Kia wrote:

Do we really need a hierarchy simplification for this part ? or is it just a cosmetic problem ?

I think that breaking the build is more than a cosmetic problem :-)

Admittedly, we have a workaround in that I changed the tarball name back to nut-x.y.z.tar.gz, but the added information (number of commits past the last tag, plus the Git hash of the actual commit) will be useful if we re-enable generating tarball snapshots. Otherwise, it looks like the development snapshot is still an official 2.6.5 release.

@clepple
Copy link
Member

clepple commented Feb 26, 2013

Since zip/jar files presumably don't have the tar 99 character limitation, and because there is very little other code in nut-*.tar.gz that a Java programmer would use, I wonder if it makes sense to split out the Java packages into their own repository.

@EmilienKia
Copy link
Contributor

Splitting makes sense. Especially as actually java package does not need any native source file to compile.
Fine for me.

@aquette
Copy link
Member Author

aquette commented Apr 2, 2013

@balooloo : can you please create a new github repository for jNut, under the networkupstools project.
Tracked as issue #22

clepple pushed a commit to networkupstools/nut-website that referenced this issue Feb 15, 2014
@clepple
Copy link
Member

clepple commented Feb 19, 2014

jNUT has been split off.

See also #102.

@clepple clepple closed this as completed Feb 19, 2014
jimklimov referenced this issue in 42ity/nut Jan 28, 2017
…/BUILD

* commit '93c72d7b4d0599afeab151f785fa7483a9fa9289':
  gen-snmp-subdriver.sh: improvements to get data
jimklimov referenced this issue in jimklimov/nut Feb 24, 2017
Complete the MGE-XML deprecation of decimation
aquette pushed a commit that referenced this issue Jul 5, 2019
aquette pushed a commit to aquette/nut that referenced this issue Nov 12, 2019
…ls#2

Signed-off-by: Arnaud Quette <ArnaudQuette@Eaton.com>
jimklimov pushed a commit that referenced this issue Feb 15, 2024
Prepare for supporting API changes in FreeIPMI 1.1.x and 1.2.x. This 2nd
patch, which completes [[SVN:3675]], addresses FRU API changes, and removes
code redundancy. This code has been tested with FreeIPMI 0.8.12 and
the latest [[FreeIPMI SVN]] trunk r9505 (reported as 1.2.0.beta2 by pkgconfig)

[[SVN:3675]] = 2012-07-16T13:18:18Z!arnaud.quette@free.fr

Fossil-ID: SVN r3733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants