drivers/tripplite.c: start using the 'X' value #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relatively ancient documentation seems to suggest that this 'firmware checksum' value can be used to indicate the firmware generation as well as the capabilities of the UPS, namely the number of independently controllable plugs.
|
LGTM, thanks. Finally rectified the CI side (alas, incomplete statuses from aborted test builds are here and corrupt the view) to say: gonna merge in the next merge-spree (to reduce the rebuilds involved) :) CC @dzomaya |
jimklimov
added
need testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relatively ancient documentation seems to suggest that this 'firmware checksum' value can be used to indicate the firmware generation as well as the capabilities of the UPS, namely the number of independently controllable plugs.
Here is where I got the information, following a hint in the driver's documentation header: https://web.archive.org/web/20161113104958/http://www.kursknet.ru/~boa/ups/stinfo_command.html
I tested the plug control on my SMART2200NET, which has two independently controllable plugs in addition to the all-inclusive load control.