clients/upsmon.c et al: introduce SHUTDOWNEXIT boolean/delay-length option [#2133] #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kupstools#2133] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added
enhancement
service/daemon start/stop
…ation, now it can [networkupstools#2133] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
Ah, the pedantic strictness... now the "noreturn" annotation is no longer valid - the method does not ALWAYS |
|
Yay, finally, issues in jenkins-dynamatrix got ironed out and the commit status backref URLs work - pointing to the log of the failed matrix cell sub-stage right from github! :) |
…finite delay between SHUTDOWNCMD and exit() [networkupstools#2133] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Oct 28, 2023
…)) annotation, now it can [networkupstools#2133]" This reverts commit 2e72638.
…)) annotation, now it can [networkupstools#2133]" This reverts commit 2e72638. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
force-pushed
the
upsmon-fsd-noexit
branch
from
201d9bd
to
cfc2d72
Compare
jimklimov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by mailing list: "secondary" systems that take long to stop their workloads can get a power-cut too early because their
upsmonexits just after callingSHUTDOWNCMDand so allow the primary to stop andkillpower. This PR makes such behavior configurable - adding an option forupsmonto linger after telling its system to shut down.TODO/Idea for further improvement: Handle numbers as the time to linger, not as a boolean?