added future warning to directed_combinatorial_laplacian for new return type #4142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -272,6 +273,10 @@ def directed_combinatorial_laplacian_matrix( | |||
| """ | |||
| from scipy.sparse import spdiags, linalg | |||
|
|
|||
| warnings.warn( | |||
There was a problem hiding this comment.
Don't we still need to figure out whether we are using scipy.sparse, pysparse, or scipy.csgraph first?
There was a problem hiding this comment.
Yes, we do -- but we were working through one function for this in the sprint and decided to make them consistent first and then once we have decided which way to proceed we could update it. Also, we might want to eventually make the type controllable too...???... Do we?
We actually had some tricky parts today due to scipy.sparse matrices turning into numpy matrices when we didn't expect them to. That could lead to memory bottlenecks.. and unexpected types too.
|
I'm closing this as it's been superseded in the transition to the scipy.sparse array interface #5139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4141 implements the necessary change.