Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combinatorial_embedding_to_pos, specify outer face #4706

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ChristopheVuillot
Copy link

This PR adds the ability for the user to specify the triangulation and outer face when computing positions of the nodes for drawing.

The solution is the one discussed in #4699 (comment)

@dschult
Copy link
Member

dschult commented Mar 29, 2021

This look great! But still will need some basic tests before merging.
Can you look at the module (relative to the algorithms directory): tests/test_planar_drawing.py?
It uses pytest and is hopefully sufficiently readable that you could add a test to make sure
the new function works with a correct input...
Probably good to also check that it gives a reasonable error if the input is not appropriate -- though I haven't thought about that for tis problem -- it might not make sense to do that...

Thank you

@ChristopheVuillot
Copy link
Author

Thanks for the feedback, I will have a look about adding tests.

@dschult dschult added this to the networkx-3.0 milestone Apr 25, 2021
@rossbar rossbar modified the milestones: networkx-2.7, networkx-3.0 Feb 12, 2022
@rossbar rossbar modified the milestones: networkx-3.0, networkx-3.1 Nov 29, 2022
@jarrodmillman jarrodmillman removed this from the 3.2 milestone Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants