Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make plots less dense, enable plotting for igraph #4791

Merged
merged 7 commits into from May 14, 2021

Conversation

MridulS
Copy link
Member

@MridulS MridulS commented May 11, 2021

No description provided.

@rossbar
Copy link
Contributor

rossbar commented May 11, 2021

Hm, there's a NotImplementedError for igraph plotting on linux... maybe a version needs to be bumped somewhere?

@MridulS
Copy link
Member Author

MridulS commented May 11, 2021

It's installing the latest available version of igraph (0.9.1) but it looks like they will be removing plotting to a temp file soon which ig.plot uses without any target, https://github.com/igraph/python-igraph/blob/52df5180289cfe916766dab4022fc6cc35caf86b/src/igraph/drawing/__init__.py#L434

I'm trying this with a matplotlib backend now.

@MridulS
Copy link
Member Author

MridulS commented May 11, 2021

the matplotlib one worked, not sure if there is a cleaner way for this.

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It'd be nice to annotate the first graph to describe what's being drawn just so it's obvious from the image itself (maybe adding axes titles would do it).

Also, do you know if the igraph layout is reproducible or is there a random component? If the latter it'd be good to provide a seed (if possible). Same with the igraph->NX example; it'd be good to make sure that the layout used in the example is reproducible, maybe by adding an explicit nx.spring_layout with a seed.

@jarrodmillman
Copy link
Member

@MridulS Could you update the igraph dependency to

python-igraph>=0.9

I am pretty sure this doesn't work on < 0.9. (You may also want to rebase on main.)

@jarrodmillman
Copy link
Member

I believe the documentation build error is fixed on the main branch.

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Mridul!

@rossbar rossbar merged commit 5974a85 into networkx:main May 14, 2021
@jarrodmillman jarrodmillman added this to the networkx-2.6 milestone May 20, 2021
MridulS added a commit to MridulS/networkx that referenced this pull request Feb 4, 2023
Make igraph plotting example render in gallery
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
Make igraph plotting example render in gallery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants