Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests and examples / doctests for nx.descendants_at_distance #5029

Merged
merged 3 commits into from Aug 23, 2021

Conversation

AndrewEckart
Copy link
Contributor

@AndrewEckart AndrewEckart commented Aug 22, 2021

Documented some examples and added a couple of unit tests for nx.descendants_at_distance. Also did some minor refactoring to eliminate an unreachable line. Increases module coverage to 100%.

Fixes #4957

@dschult dschult added this to the networkx-2.7 milestone Aug 23, 2021
Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

networkx/algorithms/traversal/breadth_first_search.py Outdated Show resolved Hide resolved
networkx/algorithms/traversal/breadth_first_search.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks @AndrewEckart !

@rossbar rossbar merged commit 850a2dc into networkx:main Aug 23, 2021
dschult pushed a commit to dschult/networkx that referenced this pull request Jan 25, 2022
…networkx#5029)

* Add unit tests and examples / doctests for nx.descendants_at_distance

* Add unit test for exception; minor refactor (fix unreachable line)
MridulS pushed a commit to MridulS/networkx that referenced this pull request Feb 4, 2023
…networkx#5029)

* Add unit tests and examples / doctests for nx.descendants_at_distance

* Add unit test for exception; minor refactor (fix unreachable line)
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
…networkx#5029)

* Add unit tests and examples / doctests for nx.descendants_at_distance

* Add unit test for exception; minor refactor (fix unreachable line)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

descendants_at_distance appears to be untested
3 participants