Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update subgraph views tests to pass with out of order execution #5683

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Update subgraph views tests to pass with out of order execution #5683

merged 1 commit into from
Jun 2, 2022

Conversation

MridulS
Copy link
Member

@MridulS MridulS commented Jun 2, 2022

pytest-randomly fails here (#4553)

@MridulS MridulS requested a review from rossbar June 2, 2022 13:07
dschult
dschult approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
It is nice to have the randomly test this sort of thing. :}

rossbar
rossbar approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MridulS ! These changes highlight one of the gotchas of using class-based organization of tests: accidental changing/persistence of state between test cases!

@rossbar rossbar merged commit 4dba24b into networkx:main Jun 2, 2022
@jarrodmillman jarrodmillman added this to the networkx-3.0 milestone Jan 6, 2023
MridulS added a commit to MridulS/networkx that referenced this pull request Feb 4, 2023
@MridulS
Update subgraph views tests to pass with out of order execution (netw…
b2dda7c 
…orkx#5683)
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
@MridulS @cvanelteren
Update subgraph views tests to pass with out of order execution (netw…
a391a14 
…orkx#5683)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschult dschult dschult approved these changes

@rossbar rossbar rossbar approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
networkx-3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MridulS @dschult @rossbar @jarrodmillman