Improve LCA input validation #5877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The graph objects already do not allow None nodes.
dschult
approved these changes
Jul 17, 2022
jarrodmillman
pushed a commit
that referenced
this pull request
Aug 21, 2022
* Remove explicit checks for None nodes. The graph objects already do not allow None nodes. * Change elif to if for raising branches.
MridulS
pushed a commit
to MridulS/networkx
that referenced
this pull request
Feb 4, 2023
* Remove explicit checks for None nodes. The graph objects already do not allow None nodes. * Change elif to if for raising branches.
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
* Remove explicit checks for None nodes. The graph objects already do not allow None nodes. * Change elif to if for raising branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor fixups I noticed while reviewing #5876:
if None in Gchecks are not necessary as it is not possible to addNoneas a node to the base graph classes (as of Raise ValueError if None is added as a node. #4892)elifinstead ofif.