Propose to make new node_link arguments keyword only. #5928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this idea of making the arguments keyword only. We have talked about moving to that treatment of input arguments where we make a distinction between required arguments (usually positional) and optional arguments (usually keyword only). It helps avoid errors where the arguments are provided in the wrong order. I think we decided that we would move toward keyword-only for new functions (after we no longer supported older versions of Python that didn't allow the keyword only syntax). This seems like a good place to start that process. I'm also fine with shifting the deprecation notification from v3.1 to v3.2 and that could be done in this PR or a separate PR. Thanks @rossbar |
jarrodmillman
approved these changes
Aug 17, 2022
dschult
approved these changes
Aug 17, 2022
jarrodmillman
pushed a commit
that referenced
this pull request
Aug 21, 2022
Propose to make new node_link args kwarg only.
MridulS
pushed a commit
to MridulS/networkx
that referenced
this pull request
Oct 12, 2022
Propose to make new node_link args kwarg only.
MridulS
pushed a commit
to MridulS/networkx
that referenced
this pull request
Feb 4, 2023
Propose to make new node_link args kwarg only.
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
Propose to make new node_link args kwarg only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an idea I had while following up on #5787
Since we're adding these new arguments to replace the strange
attrsmunging (an obvious improvement, thanks @brocla ) I thought it might make sense to set the new args to keyword only.Note - if we decide to do this, it should go in before the next release!