Add vf2pp_helpers subpackage to wheel #5975
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #5973, which didn't actually fix the problem with the doc build.
After more debugging, I determined that the problem was the
vf2pp_helpers
subpackage wasn't actually included in the wheel. I missed this in my first round of debugging that led to my mis-diagnosis in #5973 likely from accidentally usingpip -e
and still building the docs from the source directory. We should probably add/update at least one CI job to not use editable installs to catch this problem in the future, though it's worth noting that thevf2pp_helpers
subpackage appears to be unique - i.e. there are no other "helper" subpackages that are not included in an init.py somewhere.In the slightly longer term, it might be better to refactor the
vf2pp_helpers
subpackage into a submodule instead (e.g._vf2pp_helpers.py
) which should remove the need to explicitly list the extra directory in thesetup.py
. That should be straightforward, but will touch a lot of import lines, so I will leave it to a different PR.