Fix weighted MultiDiGraphs in DAG longest path algorithms + add additional tests #5988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossbar
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Thanks @stevenstrickler this looks really nice. Just one suggestion about beefing up the tests by adding a new unit test for non-default values of default_weight (ha!)
Otherwise LGTM though!
MridulS
reviewed
Oct 24, 2022
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
MridulS
added a commit
to MridulS/networkx
that referenced
this pull request
Feb 4, 2023
…ional tests (networkx#5988) * Fix weighted MultiDiGraphs in dag longest path algorithms * Add tests for MultiDiGraphs in dag longest path tests * Test non default default_weight Co-authored-by: Ross Barnowski <rossbar@berkeley.edu> * Test non default default_weight * blackify Co-authored-by: Mridul Seth <mail@mriduls.com> Co-authored-by: Ross Barnowski <rossbar@berkeley.edu> Co-authored-by: Mridul Seth <git@mriduls.com>
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
…ional tests (networkx#5988) * Fix weighted MultiDiGraphs in dag longest path algorithms * Add tests for MultiDiGraphs in dag longest path tests * Test non default default_weight Co-authored-by: Ross Barnowski <rossbar@berkeley.edu> * Test non default default_weight * blackify Co-authored-by: Mridul Seth <mail@mriduls.com> Co-authored-by: Ross Barnowski <rossbar@berkeley.edu> Co-authored-by: Mridul Seth <git@mriduls.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5987
Personally, I would find it useful to return the edge that was calculated to be the best in addition to the node to avoid having to recalculate it again whenever traversing the path, but that would break backwards compatibility with code that is using MultiDiGraphs for unweighted longest pathing by changing the return type, so I have not included it in my fix. A potential other fix would be to create separate functions for MultiDiGraphs and add a warning to dag_longest_path and dag_longest_path_length when a MultiDiGraph is supplied—preserving backwards compatibility while notifying developers about the function's inability to compute with weights.