Increased test coverage algorithms/matching.py #6095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mjh9122
changed the title
rossbar
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
LGTM, thanks @Mjh9122 - it'd be an improvement to use pytest.raises as a context manager and check against the exception messages (as well as fix the pytest import pattern), but that should be handled in a separate PR to address the whole file. Very nice additions to improve coverage!
| @@ -450,7 +450,7 @@ def test_selfloops(self): | |||
| assert not nx.is_matching(G, {(0, 0), (1, 2), (2, 3)}) | |||
| # selfloop edge in G | |||
| G.add_edge(0, 0) | |||
| assert not nx.is_matching(G, {(0, 0), (1, 2), (2, 3)}) | |||
| assert not nx.is_matching(G, {(0, 0), (1, 2)}) | |||
There was a problem hiding this comment.
Very nice catch - as originally written, the test was not hitting the intended branch!
MridulS
approved these changes
Oct 31, 2022
jarrodmillman
pushed a commit
that referenced
this pull request
Nov 1, 2022
Increased test coverage in is_matching, is_maximal_matching, is_perfect_matching
MridulS
pushed a commit
to MridulS/networkx
that referenced
this pull request
Feb 4, 2023
Increased test coverage in is_matching, is_maximal_matching, is_perfect_matching
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
Increased test coverage in is_matching, is_maximal_matching, is_perfect_matching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Black ran. Added some tests in test_matching.py to hit some untested conditionals. Should get coverage up to around 97 from 94.