Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Specifically branch off main, instead of current branch #6127

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

MridulS
Copy link
Member

@MridulS MridulS commented Oct 24, 2022

Update the new contributor documentation to branch off from main. This will make sure people are creating branches from their local copy of main instead of the current working branch.

Update the new contributor documentation to branch off from main.
This will make sure people are creating branches from their local copy
of main instead of the current working branch.
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle this should be taken care of by the step above, which has the added benefit that main is up-to-date when the branching occurs. OTOH we've been seeing a lot of submissions where the branching is clearly a problem...

I'm willing to give it a try, if only to reduce the number of PRs that have branching problems. In a perfect world, we could admonish users to really pay attention to the contributor guide, but there's only so much you can do without going into too much detail about the git branching model.

@dschult dschult merged commit 5209431 into networkx:main Oct 25, 2022
@jarrodmillman jarrodmillman added this to the networkx-2.8.8 milestone Oct 31, 2022
jarrodmillman pushed a commit that referenced this pull request Nov 1, 2022
Update the new contributor documentation to branch off from main.
This will make sure people are creating branches from their local copy
of main instead of the current working branch.
MridulS added a commit to MridulS/networkx that referenced this pull request Feb 4, 2023
…x#6127)

Update the new contributor documentation to branch off from main.
This will make sure people are creating branches from their local copy
of main instead of the current working branch.
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
…x#6127)

Update the new contributor documentation to branch off from main.
This will make sure people are creating branches from their local copy
of main instead of the current working branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants