Amount of nodes and edges have mistakes when reading adjlist file #6132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossbar
reviewed
Oct 28, 2022
networkx/readwrite/adjlist.py
Outdated
Comment on lines
65
to
69
| If spaces are embedded in the names of nodes, the parser in read_adjlist will | ||
| be confused because space is the default delimiter. The parser will not | ||
| know if a space belongs in the node name or is just a delimiter. | ||
| To avoid this problem, specify an alternate delimiter when spaces are | ||
| valid in node names. |
There was a problem hiding this comment.
Suggested change
| If spaces are embedded in the names of nodes, the parser in read_adjlist will | |
| be confused because space is the default delimiter. The parser will not | |
| know if a space belongs in the node name or is just a delimiter. | |
| To avoid this problem, specify an alternate delimiter when spaces are | |
| valid in node names. | |
| The default `delimiter=" "` will result in unexpected results if node names contain | |
| whitespace characters. |
Just a minor wording suggestion - I think keeping this as short as possible would be best. Note also that the advice to specify an alternate delimiter may not be possible if the data was generated by someone other than the user.
There was a problem hiding this comment.
Okay. I'll add that and correct it. Thank you @rossbar
|
@rossbar how about now? |
jarrodmillman
approved these changes
Nov 1, 2022
jarrodmillman
pushed a commit
that referenced
this pull request
Nov 1, 2022
) * fixes #6036 * test load centrality * test dispersion * test dispersion * dispersion test * test dispersion * bug-fixes-for-issue-6088 * deleted * fixes for 5911 * bugfix for 5911
MridulS
pushed a commit
to MridulS/networkx
that referenced
this pull request
Feb 4, 2023
…tworkx#6132) * fixes networkx#6036 * test load centrality * test dispersion * test dispersion * dispersion test * test dispersion * bug-fixes-for-issue-6088 * deleted * fixes for 5911 * bugfix for 5911
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
…tworkx#6132) * fixes networkx#6036 * test load centrality * test dispersion * test dispersion * dispersion test * test dispersion * bug-fixes-for-issue-6088 * deleted * fixes for 5911 * bugfix for 5911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5911