-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test for algorithms in current-flow-betweenness.py #6143
Improve test for algorithms in current-flow-betweenness.py #6143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chimaobi-okite!
networkx/algorithms/centrality/tests/test_current_flow_betweenness_centrality.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty of slightly refactoring the test for unconnected graphs to use parametrization and pytest.raises
as a context manager - everything LGTM! Let's put this in once CI passes. Thanks @chimaobi-okite
Hi @MridulS, please review. I also did not explicitly create an issue for it.