changed edge weights for max weight matching and added test #6145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfulekjames
force-pushed
the
fix--for-issue-5952-prev-commit
branch
2 times, most recently
from
c5b0041
to
db66b18
Compare
rfulekjames
force-pushed
the
fix--for-issue-5952-prev-commit
branch
from
db66b18
to
798d30a
Compare
rossbar
reviewed
Nov 1, 2022
There was a problem hiding this comment.
Thanks for splitting this out @rfulekjames , this LGTM; I had just one question about the wording for the newly added docstring summary. I also took the liberty of pushing up a minor formatting fix just to correct some spacing/linebreaking for the new sentence - be sure to pull that change down!
dschult
approved these changes
Nov 1, 2022
rossbar
approved these changes
Nov 9, 2022
MridulS
pushed a commit
to MridulS/networkx
that referenced
this pull request
Feb 4, 2023
changed edge weights for max weight matching and added test. Co-authored-by: Radoslav Fulek <rado@comitycard.com> Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Mjh9122
pushed a commit
to Mjh9122/networkx
that referenced
this pull request
Feb 27, 2023
changed edge weights for max weight matching and added test. Co-authored-by: Radoslav Fulek <rado@comitycard.com> Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
changed edge weights for max weight matching and added test. Co-authored-by: Radoslav Fulek <rado@comitycard.com> Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here we are splitting up the PR into two.
Fixes #5952
eulerizefunction along the lines with the discussion of a small bug in eulerian.eulerize ? #5952 so that the minimum possible number of new edges is added in the resulting graph.