Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ThinGraph example to Multi*Graph doc_strings #6160

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

nsengiyumva-wilberforce
Copy link
Contributor

This PR is for #5854

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This at least gets us to the point where the docstrings between the 4 graph classes all have an example included. In principle it'd be great to modify the subclassing example for each case (i.e. inherit from MultiGraph for the MultiGraph example) but that gets into the question of whether/how docstrings should be kept in sync with one another.

IMO this is sufficient to close #5854. Thanks @nsengiyumva-wilberforce !

@MridulS MridulS merged commit dfe47b1 into networkx:main Nov 8, 2022
@nsengiyumva-wilberforce nsengiyumva-wilberforce deleted the thin_grapg_example branch November 9, 2022 03:46
@jarrodmillman jarrodmillman added this to the networkx-3.0 milestone Nov 10, 2022
MridulS pushed a commit to MridulS/networkx that referenced this pull request Feb 4, 2023
Mjh9122 pushed a commit to Mjh9122/networkx that referenced this pull request Feb 27, 2023
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants