-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undocumented parameters in dispersion #6183
Conversation
@rossbar What do you think? |
If normalized is True (default), try out different values of alpha, b and, c to obtain maximum | ||
performance of normalized dispersion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case I think the best thing to do would be to explicitly describe how the parameters are used in the embeddedness normalization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
" To strengthen the performance of a normalized dispersion, the nodes can be ranked by the order of the function, (disp(u, v) + b)α/(emb(u, v) + c). Searching over choices of alpha, b, and, c leads to maximum performance." How about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and pushed up a suggested wording which includes the calculation explicitly as you've proposed (with rst formatting).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks for your help!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating on this @Qudirah , LGTM!
Thanks @Qudirah! |
:) |
* fixes networkx#6036 * test load centrality * test dispersion * test dispersion * dispersion test * test dispersion * bug-fixes-for-issue-6088 * deleted * bugfix for 6111 * Add suggestion for parameter description. Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
* fixes networkx#6036 * test load centrality * test dispersion * test dispersion * dispersion test * test dispersion * bug-fixes-for-issue-6088 * deleted * bugfix for 6111 * Add suggestion for parameter description. Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
* fixes networkx#6036 * test load centrality * test dispersion * test dispersion * dispersion test * test dispersion * bug-fixes-for-issue-6088 * deleted * bugfix for 6111 * Add suggestion for parameter description. Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
fixes for #6111