-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completed Testing in community.py resolves issue #6184 #6185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @Mjh9122!
I think this is ready to go, could you just remove the scipy.special test?
@MridulS Just took it out, thanks for your help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Mjh9122 !
…rkx#6185) * Completed Testing in community.py * Tried to fix import error * Tried to fix import error part 2 * Removed scipy test and sys import * Style
…rkx#6185) * Completed Testing in community.py * Tried to fix import error * Tried to fix import error part 2 * Removed scipy test and sys import * Style
…rkx#6185) * Completed Testing in community.py * Tried to fix import error * Tried to fix import error part 2 * Removed scipy test and sys import * Style
Adds testing coverage in community.py. Only branch not tested is the return statement of a nested function, which I do not know how to test. Couple of best practice questions.
Let me know of any other issues
Testing coverage increase in generators/community.py #6184