adding test coverage for isomorphism when using digraphs #6417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossbar
reviewed
Feb 28, 2023
There was a problem hiding this comment.
Generally LGTM with a couple nits, thanks @ImHereForTheCookies
|
Sorry @rossbar I never saw your comments and was just checking back now. I appreciate the comments and updated to reflect those changes, thank you! |
rossbar
reviewed
Apr 10, 2023
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
MridulS
approved these changes
Dec 13, 2023
rossbar
approved these changes
Dec 13, 2023
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
Co-authored-by: Mridul Seth <mail@mriduls.com> Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some basic test coverage while looking at Networkx. First time contributing to nx so let me know if there's anything I missed in the guidelines and I'll fix it!