Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated numpy.alltrue method #6768

Merged
merged 1 commit into from Jun 28, 2023
Merged

Conversation

eendebakpt
Copy link
Contributor

The method numpy.alltrue has been deprecated in 1.25 and will be removed in numpy 2.0. See numpy/numpy#23314

Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good and is one of those hard to find changes.

I searched for this function elsewhere in networkx and this seems to be the only location.
LGTM

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well - tests pass locally (with scipy 1.10) so the failures are unrelated, but I'll hold off on the merge button in the name of prudence! Thanks @eendebakpt

@jarrodmillman jarrodmillman added this to the 3.2 milestone Jun 27, 2023
@MridulS MridulS merged commit f03d47b into networkx:main Jun 28, 2023
18 of 37 checks passed
Alex-Markham pushed a commit to Alex-Markham/networkx that referenced this pull request Oct 13, 2023
dschult pushed a commit to BrunoBaldissera/networkx that referenced this pull request Oct 23, 2023
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants