Add max_level= argument to louvain_communities to limit macro-iterations
#6909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated docstring and responded to feedback. Ready for final review. |
rossbar
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
This LGTM, thanks @eriknw
Technically, the introduction of the new kwarg before the end of the signature could bite users relying on kwarg position to call the function, but I don't think that's very likely.
The safest thing to do would be to add max_level as kwarg-only, but I don't feel too strongly about it!
dschult
approved these changes
Feb 15, 2024
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Feb 26, 2024
…4177) We already supported `max_level=`, and this was just upstreamed to networkx here: networkx/networkx#6909 Authors: - Erik Welch (https://github.com/eriknw) Approvers: - Rick Ratzel (https://github.com/rlratzel) URL: #4177
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
…rations (networkx#6909) * Add `max_level=` argument to `louvain_communities` to limit macro-iterations * ...or None * Add docstring and update variable names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Louvain in cugraph allows
max_levelto be specified, which sets the upper limit of "macro iterations" of the Louvain algorithms (and other algorithms such as Leiden), so I thought it would be nice to upstream back to networkx.Also, I changed the variable name of the iterator from
dtoit.dsounds like a dict to me.TODO:
CC @rlratzel