New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create 3d_rotation_anime.py #7025
Conversation
@MridulS - I only need circleci but [skip test] has no effect? |
Looks like in the documentation check deatils under "Build Doc" and then searching for "Animation", line 1375 or so in the Build Doc details identifies an error that the Have you tried building the docs locally? Does the animation work there? |
I can only run the code locally, but have no documentation building setup. I'll look at the build messages, thanks for the advice! |
plt.box(False) gives error: TypeError: 'NoneType' object is not callable
Ready for review/merge, please |
View the auto-generated animations for this PR in the latest docs https://output.circle-artifacts.com/output/job/b98e4fa1-883d-41ea-9f07-6aa9a0da75cc/artifacts/0/doc/build/html/auto_examples/3d_drawing/plot_3d_rotation_anime.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When first reading this I was thinking it was more about matplotlib than about networks. But by the end I could see the usefulness as an example of how to animate plots of a network (either rotating in 3D, or showing network attributes changing in time, etc).
Thanks a lot for getting this working. I am sure it will become a popular gallery example for NetworkX.
I've found a spelling error. I didn't search for others.
This PR looks good to me!
Co-authored-by: Dan Schult <dschult@colgate.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating on this @lobpcg ! This LGTM; it might be good to split it up into multiple examples because sphinx-gallery only supports one plot for the thumbnail, but let's leave such touchups for follow-up PRs.
Add a gallery example demonstrating 3D animation for graph visualization Co-authored-by: Dan Schult <dschult@colgate.edu> Co-authored-by: Ross Barnowski <rossbar@caltech.edu>
Make a new 3d example with rotating graph animation.
Motivated by @rossbar #6893 (comment)