Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Minor touchups to tadpole and lollipop graph #7049

Merged
merged 7 commits into from Oct 31, 2023
Merged

MAINT: Minor touchups to tadpole and lollipop graph #7049

merged 7 commits into from Oct 31, 2023

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Oct 24, 2023

A very minor followup to #6999. All of the test suite changes are in 2aa6953 - I'm happy to break that out into a separate PR if they need a closer look!

@dschult
Copy link
Member

dschult commented Oct 24, 2023

Nice!
I think almost the same changes are needed in lollipop_graph, but scope-creep could end up making this really big. I believe these docs and tests are largely based on the lollipop docs and tests, so the changes should be very similar too.

I'm fine to let that go to another PR -- maybe considering all of classic.py.

Whatever you want to include here is fine with me. :)
Thanks!

@rossbar
Copy link
Contributor Author

rossbar commented Oct 25, 2023

I think almost the same changes are needed in lollipop_graph, but scope-creep could end up making this really big. I believe these docs and tests are largely based on the lollipop docs and tests, so the changes should be very similar too.

Thanks for the heads up! I went ahead and applied the similar changes to the docs and tests for lollipop_graph. I don't want to do the entire classic module in this PR, but handling both these together does indeed make sense!

@rossbar rossbar changed the title MAINT: Minor touchups to tadpole graph MAINT: Minor touchups to tadpole and lollipop graph Oct 25, 2023
dschult
dschult approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rossbar !!
This is great!

@jarrodmillman jarrodmillman merged commit 9c953e4 into networkx:main Oct 31, 2023
35 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Oct 31, 2023
Alex-Markham pushed a commit to Alex-Markham/networkx that referenced this pull request Oct 31, 2023
@rossbar
MAINT: Minor touchups to tadpole and lollipop graph (networkx#7049)
240771b 
* Docstring updates.

* Rm unused local var.

* Rm print statements from tests.

* Tweak and parametrize tadpole graph tests.

* DOC: Fixup lollipop graph docstring.

* TST: parametrize and update lollipop tests.

* DOC: Fix wrong underline length in docstring heading.
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
@rossbar @cvanelteren
MAINT: Minor touchups to tadpole and lollipop graph (networkx#7049)
3aa78e1 
* Docstring updates.

* Rm unused local var.

* Rm print statements from tests.

* Tweak and parametrize tadpole graph tests.

* DOC: Fixup lollipop graph docstring.

* TST: parametrize and update lollipop tests.

* DOC: Fix wrong underline length in docstring heading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrodmillman jarrodmillman jarrodmillman approved these changes

@dschult dschult dschult approved these changes

Assignees
No one assigned
Labels
type: Maintenance
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rossbar @dschult @jarrodmillman