Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Deprecate random_triad #7061

Merged
merged 1 commit into from Nov 8, 2023
Merged

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Oct 25, 2023

Another proposal for deprecation in the triads module. This is another one-liner "helper function". It doesn't appear to have any special meaning w.r.t triadic analysis and isn't used at all internally. The one caveat here though is that unlike "triplets" (see #7060), triads are only defined for directed graphs. In other words, if a user did nx.subgraph(G, random.sample(list(G), 3)) and G wasn't a directed graph, then this would technically not be a triad (at least given the current definitions - see #4386 for related discussion).

Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good deprecation/removal of a spurious function.
Yay!

@MridulS MridulS merged commit a8b5d06 into networkx:main Nov 8, 2023
35 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Nov 8, 2023
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants