Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused code #7076

Merged
merged 1 commit into from Oct 31, 2023
Merged

remove unused code #7076

merged 1 commit into from Oct 31, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 31, 2023

#6925 improved the resistance_distance.
I already removed some old code in #7053, but this PR removes a no-longer-used auxiliary function.

@jarrodmillman jarrodmillman merged commit 20c6c0d into networkx:main Oct 31, 2023
36 of 37 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Oct 31, 2023
rossbar
rossbar approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look at the rest of the file - I didn't notice any other unused code (except some comments which can also probably be removed) so this should cover the cleanup from #6925. Thanks @peijenburg

@ghost ghost deleted the Remove-unused-code-resistance_distance-part-2 branch November 8, 2023 19:22
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
@cvanelteren
remove unused code (networkx#7076)
bfd44d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: Maintenance
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jarrodmillman @rossbar @MridulS