Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a step to CI to check for warnings at import time. #7077

Merged
merged 1 commit into from Nov 3, 2023

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Oct 31, 2023

Related to #7064 and #7032.

This PR adds a minimal step to the default testing job to check for warnings raised at import time. I'm still not able to reproduce #7064 / #7032 locally, so I suspect that they are specific to Python config/environment management systems. Nevertheless, this is a relatively lightweight check that will hopefully help catch any user-facing import warnings prior to releases.

If anyone has ideas how this can be made more robust, please chime in!

Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@MridulS MridulS merged commit d34dd1a into networkx:main Nov 3, 2023
37 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Nov 3, 2023
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants