Update dispatch decorator for hits to use "weight" edge weight
#7081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MridulS
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
I wonder if we should expose weight in hits API. We would probably just need to change A = nx.adjacency_matrix(G, nodelist=list(G), dtype=float) to A = nx.adjacency_matrix(G, nodelist=list(G), dtype=float, weight=weight) in the implementation (assuming weighted HITS makes sense)
dschult
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
It makes good sense to me to add a 'weight' input to the hits algorithm. I'm quite surprised that it isn't there already.
This PR can be merged as is. Let's make a separate one that adds that (keyword-only)
input, changes this dispatch decorator accordingly, and changes the algorithm to use weighted adjacency matrices. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"weight"edge weight is currently fixed.