Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add docstrings to filter view functions #7086

Merged
merged 3 commits into from Nov 6, 2023
Merged

DOC: Add docstrings to filter view functions #7086

merged 3 commits into from Nov 6, 2023

Conversation

akshayamadhuri
Copy link
Contributor

issue no: #4433

@dschult
Copy link
Member

dschult commented Nov 5, 2023

To get the "style" check to pass, click on the associated "Details" link and it will show you what the style programs think you should change. In this case, a space appears starting the doc_string some of the functions. Similar style "failures" show in the cores.py PR as well.

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @akshayamadhuri ! I took the liberty of applying black and pushed up those changes to get CI passing.

@akshayamadhuri
Copy link
Contributor Author

thanks @rossbar for the commits

@MridulS MridulS changed the title Update filters.py DOC: Add docstrings to filter view functions Nov 6, 2023
@MridulS MridulS merged commit eb6c4c4 into networkx:main Nov 6, 2023
36 checks passed
@MridulS
Copy link
Member

MridulS commented Nov 6, 2023

Thanks @akshayamadhuri!

@jarrodmillman jarrodmillman added this to the 3.3 milestone Nov 6, 2023
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
* Update filters.py

* Update filters.py

* Apply black.

---------

Co-authored-by: Ross Barnowski <rossbar@caltech.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants