Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Match the doc description while copying over data #7092

Merged
merged 2 commits into from Nov 9, 2023

Conversation

MridulS
Copy link
Member

@MridulS MridulS commented Nov 7, 2023

As pointed out by @eriknw in #7066 (comment), we weren't following our own docs :)

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MridulS & @eriknw !

Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a deprecation? I'm fine with either way.

We should also test that the graph attributes are not copied.

@MridulS
Copy link
Member Author

MridulS commented Nov 8, 2023

Does this need a deprecation? I'm fine with either way.

We are fixing a bug, so I would lean on no.

Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay -- Thanks for this!

@dschult dschult merged commit 6b3f7bb into networkx:main Nov 9, 2023
38 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Nov 9, 2023
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
* FIX: Match the doc description while copying over data

* check for graph data too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants