Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add plots to classic graph generators docs #7114

Merged
merged 3 commits into from Dec 20, 2023

Conversation

MridulS
Copy link
Member

@MridulS MridulS commented Nov 15, 2023

Builds on top of #6401

I have added a seed and removed the links to download script/png/pdf from the doc build. IMO we should be using this to just quickly show how the graph looks like, we don't need to worry about making this reproducible on a pixel level.

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MridulS . I'm actually in favor of including the code snippet that produces the graphs, but we can tweak these later!

@MridulS
Copy link
Member Author

MridulS commented Nov 16, 2023

Ohh, the plot directive adds the script, png, pdf bits by default. We need to probably do something about the script as it doesn't append the pre_code_block.

Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
:)

@dschult dschult merged commit d042db5 into networkx:main Dec 20, 2023
39 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Dec 20, 2023
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
* DOC: Add plots to classic graph generators docs

* Update conf.py

* make pre-commit happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants