Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: consistent spelling of neighbor and rename vars #7162

Merged
merged 2 commits into from Dec 15, 2023
Merged

DOC: consistent spelling of neighbor and rename vars #7162

merged 2 commits into from Dec 15, 2023

Conversation

MridulS
Copy link
Member

@MridulS MridulS commented Dec 14, 2023

This addresses the comment by @dschult #4308 (comment) and also builds on top of #4309

@MridulS MridulS mentioned this pull request Dec 14, 2023
Closed
rossbar
rossbar approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing this over the finish line @MridulS , LGTM!

The doc CI failure was just a timeout - I triggered a rerun just to be safe but it should be fine.

dschult
dschult approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
I love the neighbor -> nbr for variable names... The best spelling of the word is vowel-less. :)

@dschult dschult merged commit 1c2fa4b into networkx:main Dec 15, 2023
40 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Dec 15, 2023
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
@MridulS @cvanelteren
DOC: consistent spelling of neighbor and rename vars (networkx#7162)
ea81a35 
* DOC: consistent spelling of neighbor and rename vars

* rename more vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschult dschult dschult approved these changes

@rossbar rossbar rossbar approved these changes

Assignees
No one assigned
Labels
type: Maintenance
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MridulS @dschult @rossbar @jarrodmillman