Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not_implemented_for decorator for is_regular and related functions #7182

Merged
merged 5 commits into from Dec 21, 2023

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Dec 20, 2023

Closes #7172 and #6904

@rossbar
Copy link
Contributor Author

rossbar commented Dec 20, 2023

I went ahead and pushed up the fixes for the other instances listed in #6904 as well!

Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good! Thanks!!

@MridulS MridulS added this to the 3.3 milestone Dec 21, 2023
@MridulS MridulS merged commit b7d0b0c into networkx:main Dec 21, 2023
39 checks passed
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
networkx#7182)

* Add tests for NotImplementedError for is_regular.

* Fix NetworkXNotImplemented for is_regular and related fns.

* Handle similar instances in maxcut.

* Handle similar case for asyn_fluid.

* Handle similar case for tree_isomorphism.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Should is_distance_regular and intersection_array have @not_implemented_for?
3 participants