Refactor geometric_soft_configuration_model tests for performance #7210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6858 added the
geometric_soft_configuration_model
generator, which included several tests that generated graphs with >1k nodes. These tests were quite slow:These could be decorated with
pytest.mark.slow
, but then they'd still be running in the coverage job in CI. Since the tests are pseudo-stochastic anyways (i.e. they test average properties of graphs created with a seed) I figured there was no harm in refactoring them instead to improve performance. The main thing was to drop the total number of nodes from 1000's to 10's (reducing themean_degree
as well, where necessary). I also consolidated two of the tests into one so that the input graph is only created once. These changes result in:... removing the bottlenecks and dropping the total test runtime for the module from ~10s -> 0.4s (on my machine).