Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace tempfile with tmp_path fixture in test suite. #7221

Merged
merged 2 commits into from Jan 14, 2024
Merged

Replace tempfile with tmp_path fixture in test suite. #7221

merged 2 commits into from Jan 14, 2024

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Jan 13, 2024

An alternative to #6554 which removes tempfile entirely in favor of the tmp_path fixture in the test suite.

dschult
dschult approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this interface and solution to the tempfile issues.
:)

@MridulS MridulS merged commit b2f98a4 into networkx:main Jan 14, 2024
39 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Jan 14, 2024
@MridulS MridulS mentioned this pull request Jan 14, 2024
Closed
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
@rossbar @cvanelteren
Replace tempfile with tmp_path fixture in test suite. (networkx#7221)
df28c3d 
* Replace tempfile with tmp_path fixture in test suite.

* A few more instances.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschult dschult dschult approved these changes

Assignees
No one assigned
Labels
type: Maintenance
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rossbar @dschult @jarrodmillman @MridulS