Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving test coverage for Small.py #7260

Merged
merged 2 commits into from Jan 31, 2024

Conversation

vanshika230
Copy link
Contributor

I have increased test coverage for small.py according to here :-
https://app.codecov.io/gh/networkx/networkx/blob/main/networkx/generators/small.py
The test coverage is now at a 100% as seen below :-
image
I would love a review on this and do any changes if required!

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, just a few minor suggestions to improve the specificity and formatting of the test!

networkx/generators/tests/test_small.py Outdated Show resolved Hide resolved
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vanshika230 !

Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@dschult dschult merged commit f488d08 into networkx:main Jan 31, 2024
39 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Jan 31, 2024
@vanshika230 vanshika230 deleted the test_coverage_small branch January 31, 2024 18:39
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
* Improving test coverage for Small.py

* Changes required

Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>

---------

Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants